finga/webhookey
1
0
Fork 0
Code Issues 5 Pull requests Projects Releases Wiki Activity

Multiple filters on one single hook #8

New issue
Closed
opened 2021-05-27 09:31:38 +02:00 by suchademon · 2 comments
suchademon commented 2021-05-27 09:31:38 +02:00
Copy link

I have 3 hooks placed in the webhookey config.
Each of them has one or more filters
During a test I found out, that it is not requierd that all filters match, just one filter match is enought to trigger the command.

Is that on purpose that the content of command is getting executed if only one of X filters matches?

I have 3 hooks placed in the webhookey config. Each of them has one or more filters During a test I found out, that it is not requierd that all filters match, just one filter match is enought to trigger the command. Is that on purpose that the content of command is getting executed if only one of X filters matches?
finga added the
enhancement
 label 2021-05-28 23:04:21 +02:00
finga self-assigned this 2021-05-28 23:04:28 +02:00
finga changed title from Multible filters on one single hook to Multiple filters on one single hook 2021-05-31 02:22:28 +02:00
finga commented 2021-05-31 02:39:04 +02:00
Owner
Copy link

@suchademon could you take a look at the readme and check if the changes suit your needs.

@suchademon could you take a look at the [readme](https://git.onders.org/finga/webhookey/src/branch/dev/conjunction_filters/README.md) and check if the changes suit your needs.
suchademon commented 2021-05-31 12:25:17 +02:00
Author
Copy link

@finga thank you very much, yea that should fit the needs what we have

@finga thank you very much, yea that should fit the needs what we have
finga closed this issue 2021-06-15 12:57:15 +02:00
Sign in to join this conversation.
master
Branches Tags
Clear current reference
main
testing
dev/auth
dev/hermit
Clear current reference
v0.1.6
v0.1.5
v0.1.4
v0.1.3
v0.1.2
v0.1.1
v0.1.0
v0.1.0-rc.2
v0.1.0-rc.1
v0.1.0-rc.0
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
finga
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: finga/webhookey#8
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?